[
https://issues.apache.org/jira/browse/HTTPCLIENT-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590175#comment-16590175
]
Oleg Kalnichevski commented on HTTPCLIENT-1942:
-----------------------------------------------
[~rschmitt] I am unable (or not intelligent enough) to post comments on your
code without a pending PR. I'll mention a few things here.
1. Can we remove compile dependency on {{io.reactivex.rxjava2}} or at least
make it optional?
2. {{ReactiveResponseConsumer}} with multiple futures feels funny. Why not
using a simple {{Consumer}} to signal availability of {{Message<HttpResponse,
Publisher<ByteBuffer>>}} after all? It can always stick it into a Future if
necessary.
3. Why not returning {{Future<HttpResponse>}} instead of {{Future<Void>}}?
Oleg
> Add support for Reactive Streams
> --------------------------------
>
> Key: HTTPCLIENT-1942
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1942
> Project: HttpComponents HttpClient
> Issue Type: Wish
> Components: HttpClient (async)
> Affects Versions: 5.0 Beta1
> Reporter: Ryan Schmitt
> Priority: Major
> Labels: stuck, volunteers-wanted
> Fix For: Future
>
>
> It would be very helpful to me if the Apache client provided an
> implementation of the [Reactive Streams|http://www.reactive-streams.org/]
> spec, particularly as an implementation of the standard
> [interfaces|https://search.maven.org/artifact/org.reactivestreams/reactive-streams/1.0.2/jar].
> These interfaces are JDK6-compatible and have no other dependencies, but
> they unlock interoperability with many other frameworks, such as RxJava.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
