On Mon, Oct 1, 2018 at 8:33 AM Gary Gregory <[email protected]> wrote:
> Also, since we are here, in the same place: "Header > getSingleHeader(String)", could be be "getHeader(String)"; since the > "Single" is implied by the singular "Header" in the API name _and_ by the > return type. > > Thoughts on that one? > Ping? Gary > > Gary > > > On Mon, Oct 1, 2018 at 8:21 AM Gary Gregory <[email protected]> > wrote: > >> On Mon, Oct 1, 2018 at 5:22 AM Oleg Kalnichevski <[email protected]> >> wrote: >> >>> On Sun, 2018-09-30 at 12:57 -0600, Gary Gregory wrote: >>> > IMO, we should >>> > rename org.apache.hc.core5.http.MessageHeaders.getAllHeaders() to >>> > getHeaders(). The "All" is not needed IMO. We do not have "All" in >>> > other >>> > API names, for example we have "headerIterator()" in the same class >>> > and not >>> > "allHeadersIterator()", why is "All" in one and not in the other? Do >>> > they >>> > return different results? Confusing. >>> > >>> > Gary >>> >>> I am fine with it either way. >>> >> >> Done in git master. >> >> Gary >> >> >>> >>> Oleg >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >>>
