On Sat, Nov 10, 2018 at 11:17 AM Oleg Kalnichevski <[email protected]> wrote:
> On Sat, 2018-11-10 at 18:06 +0000, [email protected] wrote: > > Repository: httpcomponents-core > > Updated Branches: > > refs/heads/master ce75b9301 -> 6ff447072 > > > > > > Javadoc. > > > > Gary > > I have a few questions > > 1. Was it really necessary to emphasize that `requiredCapacity` is > actually means `required capacity`? > > 2. Was it really useful as a single one line change in one single > class? > > 3. Is there any particular reason for not running the style checks > prior to committing code? > I did. 'mvn checkstyle:checkstyle' is not configured to run properly it seems, it only complains when I run 'mvn package'. I will fix... Gary > > Oleg > > > Project: > > http://git-wip-us.apache.org/repos/asf/httpcomponents-core/repo > > Commit: > > > http://git-wip-us.apache.org/repos/asf/httpcomponents-core/commit/6ff44707 > > Tree: > > http://git-wip-us.apache.org/repos/asf/httpcomponents-core/tree/6ff44707 > > Diff: > > http://git-wip-us.apache.org/repos/asf/httpcomponents-core/diff/6ff44707 > > > > Branch: refs/heads/master > > Commit: 6ff4470725a44a16aadbbc899def838ed402f1fd > > Parents: ce75b93 > > Author: Gary Gregory <[email protected]> > > Authored: Sat Nov 10 11:06:26 2018 -0700 > > Committer: Gary Gregory <[email protected]> > > Committed: Sat Nov 10 11:06:26 2018 -0700 > > > > ------------------------------------------------------------------- > > --- > > .../java/org/apache/hc/core5/http/impl/nio/ExpandableBuffer.java | > > 2 ++ > > 1 file changed, 2 insertions(+) > > ------------------------------------------------------------------- > > --- > > > > > > > > http://git-wip-us.apache.org/repos/asf/httpcomponents-core/blob/6ff44707/httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/ExpandableBuffer.java > > ------------------------------------------------------------------- > > --- > > diff --git > > a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/Expandabl > > eBuffer.java > > b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/Expandabl > > eBuffer.java > > index 1d75d43..261a11d 100644 > > --- > > a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/Expandabl > > eBuffer.java > > +++ > > b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/Expandabl > > eBuffer.java > > @@ -136,6 +136,8 @@ public class ExpandableBuffer { > > > > /** > > * Ensures the buffer can accommodate the required capacity. > > + * > > + * @param requiredCapacity the required capacity. > > */ > > protected void ensureCapacity(final int requiredCapacity) { > > if (requiredCapacity > this.buffer.capacity()) { > > > >
