On Sat, 2018-11-10 at 11:31 -0700, Gary Gregory wrote: > On Sat, Nov 10, 2018 at 11:17 AM Oleg Kalnichevski <[email protected]> > wrote: > > > On Sat, 2018-11-10 at 18:06 +0000, [email protected] wrote: > > > Repository: httpcomponents-core > > > Updated Branches: > > > refs/heads/master ce75b9301 -> 6ff447072 > > > > > > > > > Javadoc. > > > > > > > Gary > > > > I have a few questions > > > > 1. Was it really necessary to emphasize that `requiredCapacity` is > > actually means `required capacity`? > > > > 2. Was it really useful as a single one line change in one single > > class? > > > > 3. Is there any particular reason for not running the style checks > > prior to committing code? > > > > I did. 'mvn checkstyle:checkstyle' is not configured to run properly > it > seems, it only complains when I run 'mvn package'. I will fix... >
Just 'mvn compile' is enough. Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
