[ https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762474#comment-16762474 ]
Oleg Kalnichevski commented on HTTPCORE-570: -------------------------------------------- [~garydgregory] I think the whole thing is a mistake. Is there really a good reason to increase the API footprint of this class three-fold? What is it exactly you are trying to accomplish? Anyway, if you are convinced this is what you want. Please _do_ make similar / symmetric changes to *_all_* bootstrap classes in HttpCore. There are seven of those. Oleg > Add getters to AsyncServerBootstrap and refactor create() impl into protected > methods > ------------------------------------------------------------------------------------- > > Key: HTTPCORE-570 > URL: https://issues.apache.org/jira/browse/HTTPCORE-570 > Project: HttpComponents HttpCore > Issue Type: New Feature > Reporter: Gary Gregory > Assignee: Gary Gregory > Priority: Major > > Add getters to {{AsyncServerBootstrap}} and refactor {{create()}} > implementation into protected methods. > Right now, you can subclass {{AsyncServerBootstrap}} to customize a > {{create()}} method but you cannot get to instance variables as these are > private. > The goal is to make creating instances of {{HttpAsyncServer}} simpler by > adding getters and refactoring create() implementations into protected > methods such that subclasses can more simply create custom instances. > That does not seem controversial to me so I am not sure a feature branch is > needed but I'll create one anyway: {{HTTPCORE-570}} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org