[
https://issues.apache.org/jira/browse/HTTPCORE-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762795#comment-16762795
]
Oleg Kalnichevski commented on HTTPCORE-570:
--------------------------------------------
[~garydgregory] This is so much better if you ask me.
* I would suggest getting rid of {{uriPatternType}} parameter now.
* Please make symmetric changes to other server bootstrap classes.
* Please squash those many commits into a single one
Oleg
> Add getters to AsyncServerBootstrap and refactor create() impl into protected
> methods
> -------------------------------------------------------------------------------------
>
> Key: HTTPCORE-570
> URL: https://issues.apache.org/jira/browse/HTTPCORE-570
> Project: HttpComponents HttpCore
> Issue Type: New Feature
> Reporter: Gary Gregory
> Assignee: Gary Gregory
> Priority: Major
>
> Add getters to {{AsyncServerBootstrap}} and refactor {{create()}}
> implementation into protected methods.
> Right now, you can subclass {{AsyncServerBootstrap}} to customize a
> {{create()}} method but you cannot get to instance variables as these are
> private.
> The goal is to make creating instances of {{HttpAsyncServer}} simpler by
> adding getters and refactoring create() implementations into protected
> methods such that subclasses can more simply create custom instances.
> That does not seem controversial to me so I am not sure a feature branch is
> needed but I'll create one anyway: {{HTTPCORE-570}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
