On Mon, 2019-07-22 at 17:11 -0700, Ryan Schmitt wrote: > In testing the beta5 release, I've noticed an apparent regression in > the > async client. I have integration tests that exercise the code path > where > TLS hostname verification fails (such as due to the use of a self- > signed > certificate). On beta5, these tests hang forever, because the > `SSLPeerUnverifiedException` (thrown by `DefaultHostnameVerifier`) > doesn't > seem to result an appropriate callback to fail the request, although > it > does result in a TCP RST being sent. When I get in to work tomorrow > I'm > going to investigate this further, but I wanted to highlight this bug > for > the list in case anyone happens to know where specifically the > regression > might have occurred.
Hi Ryan Thanks for the heads up. I just realized there is no integration tests for common TLS handshake scenarios with async clients. Would you be willing to contribute some of yours or shall I create them? There are some test cases for SSLSocket factory which could be used as a starting point, but it would still take some efforts: https://github.com/apache/httpcomponents-client/blob/master/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/sync/TestSSLSocketFactory.java Cheers Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
