On Tue, 2019-07-23 at 12:21 -0700, Ryan Schmitt wrote: > The root cause is here: > > https://github.com/apache/httpcomponents-core/commit/5c28eb27ee7504386aa788fbd688d5f885b6e68f#diff-6f4c6659a6b5b77a4c947b89d59d82c1R174 > > Because we are dealing with a TLS handshake exception, a > `protocolHandler` > has not yet been set. I'm not sure how to fix this. >
I will look into it. > As for my tests, they are fairly tightly coupled to a bunch of > proprietary > stuff and would need to be completely rewritten. However, I have > written a > few useful integration test servers, in order to inject different > failures > (such as TLS handshakes that time out during this or that phase of > the > four-way handshake, or HTTP servers that time out while writing > different > parts of the response). Should I send those along? > Absolutely. That would be quite valuable. Cheers Oleg > On Tue, Jul 23, 2019 at 2:53 AM Oleg Kalnichevski <[email protected]> > wrote: > > > > > Hi Ryan > > > > Thanks for the heads up. > > > > I just realized there is no integration tests for common TLS > > handshake > > scenarios with async clients. Would you be willing to contribute > > some > > of yours or shall I create them? There are some test cases for > > SSLSocket factory which could be used as a starting point, but it > > would > > still take some efforts: > > > > > > https://github.com/apache/httpcomponents-client/blob/master/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/sync/TestSSLSocketFactory.java > > > > Cheers > > > > Oleg > > > > > > ----------------------------------------------------------------- > > ---- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
