[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983676#comment-16983676
 ] 

Gary D. Gregory commented on HTTPCLIENT-2031:
---------------------------------------------

[~michael-o] I do not have a strong feeling either way. I care about the names 
being _consistent_. Go for it.

> Don't use plural names for enums
> --------------------------------
>
>                 Key: HTTPCLIENT-2031
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2031
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient (async), HttpClient (classic)
>    Affects Versions: 5.0 Beta6
>            Reporter: Michael Osipov
>            Priority: Major
>
> In Java world, the general concensus to have enum names to be singular, yes 
> some of are in plural:
> {noformat}
> org.apache.hc.client5.http.async.methods.HttpRequests
> org.apache.hc.client5.http.async.methods.SimpleHttpRequests
> org.apache.hc.client5.http.auth.AuthSchemes
> org.apache.hc.client5.http.classic.methods.ClassicHttpRequests
> org.apache.hc.client5.http.cookie.CookieSpecs
> org.apache.hc.client5.http.impl.ChainElements
> {noformat}
> See also https://docs.oracle.com/javase/tutorial/java/javaOO/enum.html and 
> https://stackoverflow.com/a/15756009/696632
> If no one objects ([~olegk],  [~ggregory]), I will alter this on master.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to