[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149606#comment-17149606
 ] 

Carter Kozak commented on HTTPCLIENT-2094:
------------------------------------------

Proposed fix: https://github.com/apache/httpcomponents-client/pull/231

> setValidateAfterInactivity disagreement between classic/async for duration 
> zero
> -------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-2094
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2094
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Documentation, HttpClient (async), HttpClient (classic)
>    Affects Versions: 5.0.1
>            Reporter: Carter Kozak
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Pooling(Async|Http)ClientCOnnectionManager.setValidateAfterInactivity 
> documentation says that non-positive values result in no validation.
> This is true of the asynchronous implementation, however the classic 
> implementation only uses negative values to disable validation where zero 
> results in validation prior to each request.
> Ideally the semantics would match between the two connection managers. My 
> preference would be to update the documentation in both and the 
> implementation of the asynchronous manager so that zero always validates 
> connections for behavior similar to okhttp (while certainly not a good idea 
> in most cases, has benefits in environments with poor connectivity). This 
> approach would also match behavior of 4.x.
> Thoughts?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to