michael-o commented on a change in pull request #207:
URL:
https://github.com/apache/httpcomponents-core/pull/207#discussion_r461643228
##########
File path:
httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/DefaultBHttpClientConnection.java
##########
@@ -157,8 +156,8 @@ public void sendRequestEntity(final ClassicHttpRequest
request) throws HttpExcep
try (final OutputStream outStream = createContentOutputStream(
len, this.outbuffer, new OutputStream() {
- final boolean ssl = socketHolder.getSocket() instanceof
SSLSocket;
final InputStream socketInputStream =
socketHolder.getInputStream();
+ final boolean earlyResponseCheckRequiresRead =
!(socketInputStream instanceof FileInputStream);
Review comment:
This really feels like a brittle approach on implementation details.
Isn't there a better way for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
