michael-o commented on a change in pull request #219:
URL:
https://github.com/apache/httpcomponents-core/pull/219#discussion_r472126151
##########
File path:
httpcore5/src/main/java/org/apache/hc/core5/reactor/IOSessionImpl.java
##########
@@ -71,7 +71,7 @@ public IOSessionImpl(final String type, final SelectionKey
key, final SocketChan
this.commandQueue = new ConcurrentLinkedDeque<>();
this.lock = new ReentrantLock();
this.socketTimeout = Timeout.DISABLED;
- this.id = String.format(type + "-%08X", COUNT.getAndIncrement());
+ this.id = String.format(type + "-%08d", COUNT.getAndIncrement());
Review comment:
@ok2c I agree in general. I think we need to add 60%, why 16 (base)/10
(base) = 1,6. So 13 or 14. I am also OK with 20 which, though, seems quite long
to me.
@carterkozak I can live with both. Whatever the community seems better
readable/greppable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
