michael-o commented on a change in pull request #219:
URL: 
https://github.com/apache/httpcomponents-core/pull/219#discussion_r472141247



##########
File path: 
httpcore5/src/main/java/org/apache/hc/core5/reactor/IOSessionImpl.java
##########
@@ -71,7 +71,7 @@ public IOSessionImpl(final String type, final SelectionKey 
key, final SocketChan
         this.commandQueue = new ConcurrentLinkedDeque<>();
         this.lock = new ReentrantLock();
         this.socketTimeout = Timeout.DISABLED;
-        this.id = String.format(type + "-%08X", COUNT.getAndIncrement());
+        this.id = String.format(type + "-%08d", COUNT.getAndIncrement());

Review comment:
       @carterkozak While you are right, it should not read as an array. That's 
the whole point.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to