[ https://issues.apache.org/jira/browse/HTTPCORE-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17194727#comment-17194727 ]
ASF subversion and git services commented on HTTPCORE-645: ---------------------------------------------------------- Commit 9dfd5f3f869de8ae9c526ef05a8c7516db260b70 in httpcomponents-core's branch refs/heads/master from Carter Kozak [ https://gitbox.apache.org/repos/asf?p=httpcomponents-core.git;h=9dfd5f3 ] HTTPCORE-645: Chunked request streams reuse buffers between requests This adds a lazily initialized reusable buffer to the connection which is reused for all chunked request entities to avoid expensive array allocations each time a chunked request entity is sent. > Increase default chunked request body chunk size > ------------------------------------------------ > > Key: HTTPCORE-645 > URL: https://issues.apache.org/jira/browse/HTTPCORE-645 > Project: HttpComponents HttpCore > Issue Type: Improvement > Components: HttpCore > Affects Versions: 5.0.1 > Reporter: Carter Kozak > Priority: Minor > Fix For: 5.1 > > Time Spent: 40m > Remaining Estimate: 0h > > Currently the default value is 2 KiB, which is relatively small as discussed > in > [https://github.com/apache/httpcomponents-core/pull/206#discussion_r462154831] > Creating this ticket to discuss using a larger default value. The drawback to > increasing the chunk size is that the chunk cache buffer is created for each > request entity stream unlike the session buffer which is associated with a > potentially persistent connection. This will result in higher allocation > pressure for chunked request heavy uses, especially when the chunked request > body may be much smaller than the chunk hint size. In order to work around > this, the connection may create a reusable buffer based on the chunk hint > which is reused across requests. > Open questions: > Should we increase the default chunk size? > What value should we use? -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org