ok2c commented on a change in pull request #283:
URL:
https://github.com/apache/httpcomponents-client/pull/283#discussion_r574797434
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/AuthChallengeParser.java
##########
@@ -116,6 +116,7 @@ public String toString() {
params.clear();
}
}
+ if (token68 == null) token68 = "";
Review comment:
@careylam could you please explain why this change is necessary? Please
also note there are test cases failing due to this change.
I also suggest this check be moved from the `AuthChallengeParser` to the
`GGSSchemeBase` class.
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/auth/KerberosConfig.java
##########
@@ -81,6 +85,10 @@ public Option getRequestDelegCreds() {
return requestDelegCreds;
}
+ public String getServiceName() {
Review comment:
@careylam Please add `@since 5.1` tag to all new public methods
introduced in your change-set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
