careylam commented on a change in pull request #283:
URL:
https://github.com/apache/httpcomponents-client/pull/283#discussion_r574863815
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/AuthChallengeParser.java
##########
@@ -116,6 +116,7 @@ public String toString() {
params.clear();
}
}
+ if (token68 == null) token68 = "";
Review comment:
This line is to avoid GGSSchemeBase throwing
MalformedChanllengeException. The token is not in the negociate reponse header
"WWW-Authenticate: Negotiate".
I suggest to remove the null check on GGSSchemeBase. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
