michael-o commented on a change in pull request #289:
URL:
https://github.com/apache/httpcomponents-client/pull/289#discussion_r592245048
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/cookie/SetCookie.java
##########
@@ -85,5 +85,14 @@
*/
void setSecure (boolean secure);
+ /**
+ * Sets the {@code httpOnly} attribute of the cookie.
Review comment:
Use canonical name
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/cookie/BasicClientCookie.java
##########
@@ -215,6 +215,19 @@ public void setSecure (final boolean secure) {
isSecure = secure;
}
+ /**
+ * Sets the http-only attribute of the cookie.
+ *
+ * @param httpOnly true if this cookie is to be marked as
+ * <i>HttpOnly</i>, false otherwise
Review comment:
Here
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/cookie/SetCookie.java
##########
@@ -85,5 +85,14 @@
*/
void setSecure (boolean secure);
+ /**
+ * Sets the {@code httpOnly} attribute of the cookie.
+ *
+ * @param httpOnly The value of the httpOnly attribute
Review comment:
There is no value, it is either on or off
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/cookie/Cookie.java
##########
@@ -126,5 +127,15 @@
*/
Date getCreationDate();
+ /**
+ * Checks whether this Cookie has been marked as <i>HttpOnly</i>.
Review comment:
Here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
