arturobernalg commented on pull request #289: URL: https://github.com/apache/httpcomponents-client/pull/289#issuecomment-798441727
> > Do i have to change something? or maybe adapt part of the code > > @arturobernalg Yes, you do. One cannot just add a new method to an existing interface. One must must provide a default implementation of it in order to ensure backward compatibility with existing consumers of that interface. See `TransportSecurityLayer` as an example of an interface that has a new method added to it in 5.2 > > https://github.com/apache/httpcomponents-core/blob/master/httpcore5/src/main/java/org/apache/hc/core5/reactor/ssl/TransportSecurityLayer.java#L77 HI @ok2c I guess it's the same case with SetCookie interface. I should provide a default implementation. Correct? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
