ok2c commented on a change in pull request #296:
URL:
https://github.com/apache/httpcomponents-client/pull/296#discussion_r601228940
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java
##########
@@ -113,10 +116,12 @@
private final HttpClientConnectionOperator connectionOperator;
private final ManagedConnPool<HttpRoute, ManagedHttpClientConnection> pool;
private final HttpConnectionFactory<ManagedHttpClientConnection>
connFactory;
+ private final ConcurrentMap<HttpRoute, SocketConfig> socketConfigMap;
+ private final ConcurrentMap<HttpRoute, ConnectionMgmtConfig>
connectionMgmtConfigMap;
Review comment:
@carterkozak Using a `Provider` interface for the same end is a great
idea. Thank you!
I will re-work the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
