ok2c commented on a change in pull request #296:
URL:
https://github.com/apache/httpcomponents-client/pull/296#discussion_r601336300
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/config/RequestConfig.java
##########
@@ -43,7 +43,6 @@
public class RequestConfig implements Cloneable {
private static final Timeout DEFAULT_CONNECTION_REQUEST_TIMEOUT =
Timeout.ofMinutes(3);
- private static final Timeout DEFAULT_CONNECT_TIMEOUT =
Timeout.ofMinutes(3);
private static final TimeValue DEFAULT_CONN_KEEP_ALIVE =
TimeValue.ofMinutes(3);
Review comment:
>
>
> Another stupid question: `DEFAULT_CONN_KEEP_ALIVE` applies to the lifetime
of the connection. Why is is retained here and not moved to the new config
class?
The `keep-alive` period is determined on a per request basis, generally
based on `Keep-Alive` header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
