ok2c commented on a change in pull request #296:
URL:
https://github.com/apache/httpcomponents-client/pull/296#discussion_r602103397
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/config/RequestConfig.java
##########
@@ -43,7 +43,6 @@
public class RequestConfig implements Cloneable {
private static final Timeout DEFAULT_CONNECTION_REQUEST_TIMEOUT =
Timeout.ofMinutes(3);
Review comment:
@michael-o This really depends how one looks at it. This setting is used
by each and every request and as such makes sense at the request level.
However, indeed, the inner machinery is entirely in the connection manager's
responsibility.
I initially moved that parameter to `ConnectionConfig` but if I remember it
correctly you questioned that decision.
Basically as far as I am concerned it can be either way. Blonds or
Brunettes, so to speak. However I tend to see it more of a request level
setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
