carterkozak commented on a change in pull request #296:
URL:
https://github.com/apache/httpcomponents-client/pull/296#discussion_r601857878
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java
##########
@@ -243,6 +245,16 @@ private InternalConnectionEndpoint cast(final
ConnectionEndpoint endpoint) {
throw new IllegalStateException("Unexpected endpoint class: " +
endpoint.getClass());
}
+ private ConnectionConfig resolveConnectionConfig(final HttpRoute route) {
+ final ConnectionConfig connectionConfig = connectionConfigResolver !=
null ? connectionConfigResolver.resolve(route) : null;
+ return connectionConfig != null ? connectionConfig :
ConnectionConfig.DEFAULT;
+ }
+
+ private SocketConfig resolveSocketConfig(final HttpRoute route) {
+ final SocketConfig socketConfig = socketConfigResolver != null ?
socketConfigResolver.resolve(route) : null;
+ return socketConfig != null ? socketConfig : SocketConfig.DEFAULT;
Review comment:
These two methods should use a single volatile read on the resolver as
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
