[ 
https://issues.apache.org/jira/browse/HTTPCLIENT-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carter Kozak resolved HTTPCLIENT-2148.
--------------------------------------
    Fix Version/s: 5.1-beta2
                   5.0.4
       Resolution: Fixed

Merged to master and 5.0.x.

Aside: I've seen this shape of issue in a few places, I've added a note to my 
personal backlog to try writing a static analysis check to detect these kinds 
of problems more easily.

> fluent Executor volatile access allows NPEs
> -------------------------------------------
>
>                 Key: HTTPCLIENT-2148
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-2148
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Fluent HC
>            Reporter: Carter Kozak
>            Assignee: Carter Kozak
>            Priority: Major
>             Fix For: 5.0.4, 5.1-beta2
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The {{org.apache.hc.client5.http.fluent.Executor}} class checks volatile 
> fields for null before loading them a second time for execution. If the field 
> is updated to null at runtime, this can result in a NPE.
> Even when this doesn't result in failures, it's better for performance if we 
> can use a single volatile load rather than two.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to