ok2c commented on pull request #283: URL: https://github.com/apache/httpcomponents-core/pull/283#issuecomment-818477704
> > > I'm happy to add such tests, but I'm a bit unclear what the expected behaviour ought to be. I'm inclined to require non-null, non-empty for `param` but actually other `URIBuilder` methods don't seem to exclude "" for a name (is that really permissible?). `BasicNameValuePair` guards only against null too). @peterdettman I think just `null` check should be enough for now. The issue of name/value pairs with an empty name should be dealt with consistently across the entire library. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
