ok2c commented on a change in pull request #353:
URL:
https://github.com/apache/httpcomponents-client/pull/353#discussion_r825328381
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/DefaultAsyncClientConnectionOperator.java
##########
@@ -141,15 +155,25 @@ public void upgrade(
final ManagedAsyncClientConnection connection,
final HttpHost host,
final Object attachment) {
- upgrade(connection, host, attachment, null);
+ upgrade(connection, host, attachment, null, null);
}
@Override
public void upgrade(
final ManagedAsyncClientConnection connection,
final HttpHost host,
final Object attachment,
- final FutureCallback<ManagedAsyncClientConnection> callback) {
+ final HttpContext context) {
+ upgrade(connection, host, attachment, null, context);
+ }
+
+ @Override
+ public void upgrade(
+ final ManagedAsyncClientConnection connection,
+ final HttpHost host,
+ final Object attachment,
+ final FutureCallback<ManagedAsyncClientConnection> callback,
+ final HttpContext context) {
Review comment:
@reta For the sake of API consistency, could you please keep the
callback as the last parameter? Otherwise looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
