ok2c commented on a change in pull request #353:
URL:
https://github.com/apache/httpcomponents-client/pull/353#discussion_r825328731
##########
File path:
httpclient5/src/main/java/org/apache/hc/client5/http/nio/AsyncClientConnectionOperator.java
##########
@@ -86,18 +113,35 @@
* @param host the address of the opposite endpoint with TLS security.
* @param attachment the attachment, which can be any object representing
custom parameter
* of the operation.
- *
+ * @param callback the future result callback.
+ * @param context the execution context.
* @since 5.2
*/
default void upgrade(
ManagedAsyncClientConnection conn,
HttpHost host,
Object attachment,
- FutureCallback<ManagedAsyncClientConnection> callback) {
- upgrade(conn, host, attachment);
+ FutureCallback<ManagedAsyncClientConnection> callback,
+ HttpContext context) {
Review comment:
@reta Sure thing. The connection operators are considered internal APIs,
so technically we can do with them whatever we please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
