hanasakari commented on PR #350:
URL: 
https://github.com/apache/httpcomponents-core/pull/350#issuecomment-1166243049

   this code
   
   ```
           else {
               hostName = tokenizer.parseContent(s, cursor, 
URISupport.PORT_SEPARATORS);
               if (!TextUtils.isAllASCII(hostName)) {
                   hostname = IDN.toASCII(hostname)
               }
           }
   ```
   IDE tips
   Variable 'hostName' might already have been assigned to
   
   so change to
   
   ```
   // If the hostName contains non-ASCII characters, IDNA processing is required
   hostName = TextUtils.isAllASCII(s) ?
         tokenizer.parseContent(s, cursor, URISupport.PORT_SEPARATORS) :
         IDN.toASCII(tokenizer.parseContent(s, cursor, 
URISupport.PORT_SEPARATORS));
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to