ok2c commented on PR #350: URL: https://github.com/apache/httpcomponents-core/pull/350#issuecomment-1166349416
@hanasakari There is still a problem. The routine must work with the content of `s within the bounds specified by the `cursor`. Your code does not take the `cursor` into account when executing `TextUtils#isAllASCII`. This is the reason the content of `s` should be parsed first and then tested with `TextUtils#isAllASCII`. Make `hostName` non-final if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
