jkmcl commented on code in PR #355:
URL:
https://github.com/apache/httpcomponents-core/pull/355#discussion_r912075386
##########
httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java:
##########
@@ -1033,22 +1033,22 @@ public URIBuilder normalizeSyntax() {
if (this.pathSegments != null) {
final List<String> inputSegments = this.pathSegments;
if (!inputSegments.isEmpty()) {
- final Stack<String> outputSegments = new Stack<>();
+ final LinkedList<String> outputSegments = new LinkedList<>();
Review Comment:
Performance. Stack extends Vector which is synchronized but LinkedList is
not synchronized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
