jkmcl commented on code in PR #355:
URL:
https://github.com/apache/httpcomponents-core/pull/355#discussion_r912135686
##########
httpcore5/src/main/java/org/apache/hc/core5/util/Deadline.java:
##########
@@ -60,12 +60,12 @@ public class Deadline {
/**
* The maximum (longest-lived) deadline.
*/
- public static Deadline MAX_VALUE = new Deadline(INTERNAL_MAX_VALUE);
+ public static final Deadline MAX_VALUE = new Deadline(INTERNAL_MAX_VALUE);
/**
* The minimum (shortest-lived) deadline.
*/
- public static Deadline MIN_VALUE = new Deadline(INTERNAL_MIN_VALUE);
+ public static final Deadline MIN_VALUE = new Deadline(INTERNAL_MIN_VALUE);
Review Comment:
Sure, I've reverted those 2 commits. Please consider making
`Deadline.MIN_VALUE` and `Deadline.MAX_VALUE` final in the future when the API
is revised. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
