On Wed, Sep 28, 2022, 12:42 Michael Osipov <[email protected]> wrote:
> Am 2022-09-28 um 14:49 schrieb Kalnichevski Oleg: > > Gary > > > > I am sorry that I have to say that but your latest changes to both core > > and client projects are _not_ okay. Replacing for-loops with lambdas are > > _not_ okay. Making style changes based on personal preferences without > > discussing them first is _not_ okay. > > > > Please kindly revert `Use Java 8 features and APIs` changes. > > Can you explain? > > Some of the changes is enhanced for loops and the lambdas make it more > compact. It doesn't seem to be necessarily bad. > Not only that but that's how I write code today anyway. The flip side is why would one write code that expands the looping construct when it is not needed? Regarding tradeoffs, one kind of for loop (Java 5) uses an iterator while the other a stream (Java 8), so some type of object is in play anyway. Since network stacks and latency is in play, that's the factor more likely to skew performance than anything else in a realistic benchmark IMO. Gary > M > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
