I'm afraid Oleg sound rude, disrespectful and threatening, so I'll ignore this message.
Gary On Wed, Sep 28, 2022, 13:25 Oleg Kalnichevski <ol...@apache.org> wrote: > On Wed, 2022-09-28 at 18:42 +0200, Michael Osipov wrote: > > Am 2022-09-28 um 14:49 schrieb Kalnichevski Oleg: > > > Gary > > > > > > I am sorry that I have to say that but your latest changes to both > > > core > > > and client projects are _not_ okay. Replacing for-loops with > > > lambdas are > > > _not_ okay. Making style changes based on personal preferences > > > without > > > discussing them first is _not_ okay. > > > > > > Please kindly revert `Use Java 8 features and APIs` changes. > > > > Can you explain? > > > > Some of the changes is enhanced for loops and the lambdas make it > > more > > compact. It doesn't seem to be necessarily bad. > > > > M > > Do I really need to explain? HttpCore is a low level library, so > performance matters more than synthetic sugar and personal perception > of aesthetics. > > > I would not give a fuck if it was new code and a new feature > contribution. But what is _really_ bad is making non-functional, > completely useless changes to the entire code base without any attempt > at a prior discussion, let alone an agreement. > > Please revert those changes or I will. > > Oleg > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org > For additional commands, e-mail: dev-h...@hc.apache.org > >
