davewichers commented on PR #387: URL: https://github.com/apache/httpcomponents-client/pull/387#issuecomment-1313874158
@rschmitt - In general, with a pom file you specify the specific version. I believe pom's allow you to specify a minimum, but the risk is that if the library releases a new incompatible version, that might cause a problem. So projects generally specify specific library versions. @ok2c - Yes - I am suggesting you upgrade. But I don't consider this a major upgrade since SLF4J API 2 is backward compatible with v1. So you just upgrade the version, it 'just works', and everything is good to go. And it helps users of your library avoid having to put in exclusions for the v1 version in order to avoid Dependency Convergence conflicts. And given Java 1.7 is WAY deprecated, requiring Java 8 shouldn't harm any of your users. If someone REALLY needs Java 7, they can suppress your SLF4J API version and put a 1.x version back (but that's not likely these days). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
