ok2c commented on code in PR #418:
URL:
https://github.com/apache/httpcomponents-client/pull/418#discussion_r1121977585
##########
httpclient5/src/main/java/org/apache/hc/client5/http/SystemDefaultDnsResolver.java:
##########
@@ -40,7 +40,14 @@ public class SystemDefaultDnsResolver implements DnsResolver
{
@Override
public InetAddress[] resolve(final String host) throws
UnknownHostException {
- return InetAddress.getAllByName(host);
+ try {
Review Comment:
@arturobernalg This approach has a substantial drawback: DNS lookup failures
completely unrelated to LLv6 will not generate two DNS queries. For some
applications it may be not a big deal but for some it may. What is the problem
with always calling `#stripsIPv6ZoneId` prior to calling
`InetAddress#getAllByName`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
