ok2c commented on code in PR #418:
URL:
https://github.com/apache/httpcomponents-client/pull/418#discussion_r1122259452
##########
httpclient5/src/main/java/org/apache/hc/client5/http/SystemDefaultDnsResolver.java:
##########
@@ -40,7 +40,14 @@ public class SystemDefaultDnsResolver implements DnsResolver
{
@Override
public InetAddress[] resolve(final String host) throws
UnknownHostException {
- return InetAddress.getAllByName(host);
+ try {
Review Comment:
@arturobernalg Repeating the same DNS query with the same input makes no
sense and a lot of folks will be upset due to unnecessary execution costs.
Please make sure the second query gets executed only if anything got stripped
and the input is not the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
