arturobernalg opened a new pull request, #431: URL: https://github.com/apache/httpcomponents-client/pull/431
**Summary** This pull request adds support for IDN conversion in the schemePortResolver for HTTP client requests. When enableIDNConversion is set to true and schemePortResolver is null, a new DefaultSchemePortResolver object is created with a custom implementation that uses the IDN.toASCII method to convert hostnames to ASCII format. This is compliant with RFC 5891 and helps to avoid issues with non-ASCII hostnames in HTTP requests. **Changes Made** Added null check for schemePortResolver and creation of new DefaultSchemePortResolver object if it is null and enableIDNConversion is true. Implemented custom resolve method in DefaultSchemePortResolver object to perform IDN conversion using IDN.toASCII method. Testing Created unit tests to verify that IDN conversion works as expected. Ran existing test suite to ensure that no existing functionality is broken. Notes This pull request does not modify any existing behavior when enableIDNConversion is false or schemePortResolver is already set. The changes made in this pull request are compliant with RFC 5891 and help to avoid issues with non-ASCII hostnames in HTTP requests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
