arturobernalg commented on PR #449: URL: https://github.com/apache/httpcomponents-client/pull/449#issuecomment-1548693023
> @arturobernalg I have started working on Cache-Control improvements throughout the entire HTTP cache code. I added `RequestCacheControl` to represent request cache control directives similar to `CacheControl`. Please take a look and let me know if you find anything disagreeable. As the next step I will try to make sure the request and response `Cache-Control` headers in the request and the response get parted only once instead of multiple times in various places. > > We may want to rename `CacheControl` to `ResponseCacheControl` for consistency. Please let me know what you think. @ok2c Regarding renaming 'CacheControl' to 'ResponseCacheControl', I'm in agreement with this proposal. It brings clarity and consistency to our codebase, thereby enhancing its comprehensibility. Have we considered the possibility of creating an abstract class for common directives? Overall, it looks good. By the way, the use of 'BiConsumer' is a nice touch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
