arturobernalg commented on code in PR #449:
URL:
https://github.com/apache/httpcomponents-client/pull/449#discussion_r1199656964
##########
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/CachingExec.java:
##########
@@ -290,38 +293,38 @@ private ClassicHttpResponse handleCacheHit(
if (requestContainsNoCacheDirective(request)) {
Review Comment:
We can The method 'requestContainsNoCacheDirective' also parses the request,
but we have already done that. We should simply pass the RequestCacheControl.
Also, it should be RequestCacheControl, not ResponseCacheControl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
