ok2c commented on code in PR #712: URL: https://github.com/apache/httpcomponents-client/pull/712#discussion_r2297708092
########## httpclient5/src/main/java/org/apache/hc/client5/http/config/RequestConfig.java: ########## @@ -549,6 +549,13 @@ public Builder setConnectTimeout(final long connectTimeout, final TimeUnit timeU * configured appropriately. * </p> * <p> + * This parameter may override a socket timeout configured at the connection + * or I/O layers for the duration of a message execution. It is not a hard Review Comment: @LichKing-lee Not quite. It does not apply to the entire duration of a message exchange. It defines the maximum period of inactivity between sending of a request and receipt of a message head. Once a response has been received the connection socket timeout gets reset back to its previous value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org