ok2c commented on code in PR #556:
URL:
https://github.com/apache/httpcomponents-core/pull/556#discussion_r2395715979
##########
httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/ServerBootstrap.java:
##########
@@ -346,6 +347,16 @@ public final ServerBootstrap addFilterLast(final String
name, final HttpFilterHa
return this;
}
+ /**
+ * Create {@link RequestRouter} with LOCAL_AUTHORITY_RESOLVER (default:
IGNORE_PORT_AUTHORITY_RESOLVER).
Review Comment:
@cdw8j Please do not mention `LOCAL_AUTHORITY_RESOLVER` and
`IGNORE_PORT_AUTHORITY_RESOLVER`. This is an implementation details and it
should be mentioned in javadocs
##########
httpcore5/src/main/java/org/apache/hc/core5/http/impl/bootstrap/ServerBootstrap.java:
##########
@@ -346,6 +347,16 @@ public final ServerBootstrap addFilterLast(final String
name, final HttpFilterHa
return this;
}
+ /**
+ * Create {@link RequestRouter} with LOCAL_AUTHORITY_RESOLVER (default:
IGNORE_PORT_AUTHORITY_RESOLVER).
+ *
+ * @since 5.4
+ */
+ public final ServerBootstrap useLocalAuthorityResolver(final boolean
localAuthorityResolver) {
Review Comment:
@cdw8j Please use a better name for the method. `#routeToLocalAuthority` for
example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
