ok2c commented on code in PR #581:
URL:
https://github.com/apache/httpcomponents-core/pull/581#discussion_r2705746734
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/CancellableExecution.java:
##########
@@ -48,7 +49,11 @@ public void setDependency(final Cancellable cancellable) {
if (cancelled.get()) {
final Cancellable dependency = dependencyRef.getAndSet(null);
if (dependency != null) {
- dependency.cancel();
+ try {
Review Comment:
@arturobernalg This looks like the wrong place to handle this exception.
What method throws it in the first place? Can we move this problem into a
separate PR and correct it first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
