ok2c commented on code in PR #581:
URL:
https://github.com/apache/httpcomponents-core/pull/581#discussion_r2706011530
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/CancellableExecution.java:
##########
@@ -48,7 +49,11 @@ public void setDependency(final Cancellable cancellable) {
if (cancelled.get()) {
final Cancellable dependency = dependencyRef.getAndSet(null);
if (dependency != null) {
- dependency.cancel();
+ try {
Review Comment:
@arturobernalg This fix needs to be cherry-picked to the stable 5.4.x branch
and it would be easier if it was in a separate pull request.
Another thing is I would like to understand is why it gets thrown in the
first place and if it is safe to just ignore. Could you post the original
exception stack trace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
