ok2c commented on code in PR #606: URL: https://github.com/apache/httpcomponents-core/pull/606#discussion_r2807323226
########## httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java: ########## Review Comment: @arturobernalg I will test this new feature some more using the example you have provided, but overall this looks good to me, as far as I am concerned. Is there a reason it needs to be more complex? One minor nitpick. There is a new method `#hasBeenIdleTooLong` that does not appear to be used. Either use it or remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
