ok2c commented on code in PR #606:
URL:
https://github.com/apache/httpcomponents-core/pull/606#discussion_r2807858310
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java:
##########
@@ -148,6 +149,9 @@ enum SettingsHandshake { READY, TRANSMITTED, ACKED }
private static final long STREAM_TIMEOUT_GRANULARITY_MILLIS = 1000;
private long lastStreamTimeoutCheckMillis;
+ private final Timeout validateAfterInactivity;
+ private long lastActivityTime;
Review Comment:
@arturobernalg Why do you need two variables that here? Are you sure this
makes sense?
```
private long lastActivityTime;
private volatile long lastActivityMillis;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
