ok2c commented on code in PR #710:
URL:
https://github.com/apache/httpcomponents-core/pull/710#discussion_r4137928697
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java:
##########
@@ -1491,7 +1489,7 @@ ByteBuffer getContent() {
}
- H2StreamChannel createChannel(final int streamId) {
Review Comment:
@rp-arielrodriguez Why do you need to expose the Impl class here? That looks
wrong.
Also initially please try to fix the problem with as few changes as
possible. If you want to make further improvements beyond fixing the defect
(such as adding `#isOutputAllowed` and such) please do it in a separate
change-set. The fix itself will be cherry-picked to `5.4.x`. Code improvements
will go into master only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
