ok2c commented on code in PR #710:
URL:
https://github.com/apache/httpcomponents-core/pull/710#discussion_r4142132624
##########
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/AbstractH2StreamMultiplexer.java:
##########
@@ -524,6 +524,11 @@ public final void onOutput() throws HttpException,
IOException {
if (connState.compareTo(ConnectionHandshake.SHUTDOWN) < 0) {
+ // Reset cancelled half-closed streams before the flow control
check:
Review Comment:
@rp-arielrodriguez Can we optimize it a little to avoid one extra full scan
of all streams?
```
if (connOutputWindow.get() > 0 && remoteSettingState ==
SettingsHandshake.ACKED) {
produceOutput(); // do rest if canceled inside
#produceOutput
} else {
// do rest if canceled
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
