arturobernalg commented on PR #908: URL: https://github.com/apache/httpcomponents-client/pull/908#issuecomment-6521102318
@rursprung I am not convinced we should automatically replace the connection manager when `CONN_POOL` metrics are enabled. We already provide explicit wrappers for lease instrumentation. Making enable() modify the connection manager introduces additional complexity and depends on configuration order and internal builder APIs. It also does not cover the default connection manager. I understand the `OpenSearch` use case, but I would rather keep connection manager instrumentation explicit than introduce this implicit behavior. There is also a reproducible issue with repeated enable() calls: a non-pooling manager ends up exposing pool gauges because the metered wrapper implements `ConnPoolControl`. I would prefer a more explicit approach that addresses the original use case without changing the existing enable() semantics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
