arturobernalg commented on PR #908: URL: https://github.com/apache/httpcomponents-client/pull/908#issuecomment-6625722170
I think we should keep connection manager instrumentation explicit. The OpenSearch use case can already be handled in the builder callback using meteredAsyncConnectionManager() and setConnectionManager(). I verified that this correctly records lease metrics and pool gauges. Automatically replacing the connection manager in enable() introduces configuration-order dependencies and changes the builder’s behavior. It also causes incorrect pool gauges with non-pooling managers when enable() is called repeatedly. I do not think the additional complexity is justified. I would prefer to close this PR and document the explicit approach instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
