arturobernalg commented on PR #730: URL: https://github.com/apache/httpcomponents-core/pull/730#issuecomment-6561453701
I have reverted to the version you approved, with the 100 ms sleep, and withdrawn the non-blocking variant I had pushed. It was three times the code, and in my measurements the only difference is about 50 ms on listen() and shutdown while descriptors are exhausted, so it is not worth the review. The description no longer mentions it. One limitation remains and is noted there: ServerSocketChannel.open() failing under the same condition during listen() or resume() still stops the reactor. I can send that as a separate small PR if you want it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
