Copilot commented on code in PR #937: URL: https://github.com/apache/httpcomponents-client/pull/937#discussion_r4563571529
########## httpclient5-bom/pom.xml: ########## @@ -0,0 +1,94 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ==================================================================== + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + ==================================================================== + + This software consists of voluntary contributions made by many + individuals on behalf of the Apache Software Foundation. For more + information on the Apache Software Foundation, please see + <http://www.apache.org />. + --> + <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.httpcomponents</groupId> + <artifactId>httpcomponents-parent</artifactId> + <version>15</version> + <relativePath/> + </parent> + <groupId>org.apache.httpcomponents.client5</groupId> + <artifactId>httpclient5-bom</artifactId> + <version>5.7-beta2-SNAPSHOT</version> + <packaging>pom</packaging> + <name>Apache HttpComponents Client BOM</name> + <description>Bill of Materials for Apache HttpComponents Client</description> + <url>https://hc.apache.org/httpcomponents-client-5.7.x/</url> + <properties> + <javaVersion>8</javaVersion> + <minimalJavaBuildVersion>17</minimalJavaBuildVersion> + <maven.compiler.source>${javaVersion}</maven.compiler.source> + <maven.compiler.target>${javaVersion}</maven.compiler.target> + <!-- A BOM has no bytecode to check. --> + <animal.sniffer.skip>true</animal.sniffer.skip> + </properties> Review Comment: `minimalJavaBuildVersion` is set to 17 while `javaVersion` / compiler source+target are set to 8. In many builds this will trigger Maven Enforcer (or similar) to require JDK 17 just to build a BOM, which is likely unintended and can break CI/release builds. Recommendation: align `minimalJavaBuildVersion` with the project’s actual minimum build JDK for this reactor, or remove compiler-related properties entirely for the BOM module (since it produces no bytecode). ########## httpclient5-bom/pom.xml: ########## @@ -0,0 +1,94 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ==================================================================== + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + ==================================================================== + + This software consists of voluntary contributions made by many + individuals on behalf of the Apache Software Foundation. For more + information on the Apache Software Foundation, please see + <http://www.apache.org />. + --> + <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.httpcomponents</groupId> + <artifactId>httpcomponents-parent</artifactId> + <version>15</version> + <relativePath/> + </parent> + <groupId>org.apache.httpcomponents.client5</groupId> + <artifactId>httpclient5-bom</artifactId> + <version>5.7-beta2-SNAPSHOT</version> Review Comment: This module is added to the root reactor (`<module>httpclient5-bom</module>`), but it does not inherit from the repository’s root/aggregator POM. That increases the chance of configuration drift (pluginManagement, enforcer rules, distributionManagement, shared properties) and forces duplicating coordinates (e.g., version). Recommendation: make `httpclient5-bom` inherit from the root project POM (typical for reactor modules) and rely on inherited `groupId`/`version`, or if it is intentionally standalone, consider not including it as a reactor module. ########## httpclient5-bom/pom.xml: ########## @@ -0,0 +1,94 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + ==================================================================== + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + ==================================================================== + + This software consists of voluntary contributions made by many + individuals on behalf of the Apache Software Foundation. For more + information on the Apache Software Foundation, please see + <http://www.apache.org />. + --> + <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> Review Comment: The POM namespace and schemaLocation use `http://` URLs. While typically not fetched during normal builds, using `https://` is the current best practice and avoids issues in hardened environments that block plain HTTP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
